OrgGo/tview
1
0
Fork 0
mirror of https://github.com/rivo/tview.git synced 2025-04-26 13:49:06 +08:00
Code Issues Projects Releases Wiki Activity

When a page with focus is removed, we should not end up with no focus anywhere. Also some simplifications.

Browse Source
This commit is contained in:
Oliver 2018-01-21 21:50:11 +01:00
parent ef6026df3d
commit 03571f15bb
1 changed files with 22 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
pages.go
View File

@ -67,7 +67,9 @@ func (p *Pages) AddPage(name string, item Primitive, resize, visible bool) *Page
if p.changed != nil { if p.changed != nil {
p.changed() p.changed()
} }
p.refocus() if p.HasFocus() {
p.Focus(p.setFocus)
}
return p return p
} }
@ -81,6 +83,7 @@ func (p *Pages) AddAndSwitchToPage(name string, item Primitive, resize bool) *Pa
// RemovePage removes the page with the given name. // RemovePage removes the page with the given name.
func (p *Pages) RemovePage(name string) *Pages { func (p *Pages) RemovePage(name string) *Pages {
hasFocus := p.HasFocus()
for index, page := range p.pages { for index, page := range p.pages {
if page.Name == name { if page.Name == name {
p.pages = append(p.pages[:index], p.pages[index+1:]...) p.pages = append(p.pages[:index], p.pages[index+1:]...)
@ -90,7 +93,9 @@ func (p *Pages) RemovePage(name string) *Pages {
break break
} }
} }
p.refocus() if hasFocus {
p.Focus(p.setFocus)
}
return p return p
} }
@ -116,7 +121,9 @@ func (p *Pages) ShowPage(name string) *Pages {
break break
} }
} }
p.refocus() if p.HasFocus() {
p.Focus(p.setFocus)
}
return p return p
} }
@ -131,7 +138,9 @@ func (p *Pages) HidePage(name string) *Pages {
break break
} }
} }
p.refocus() if p.HasFocus() {
p.Focus(p.setFocus)
}
return p return p
} }
@ -148,7 +157,9 @@ func (p *Pages) SwitchToPage(name string) *Pages {
if p.changed != nil { if p.changed != nil {
p.changed() p.changed()
} }
p.refocus() if p.HasFocus() {
p.Focus(p.setFocus)
}
return p return p
} }
@ -167,7 +178,9 @@ func (p *Pages) SendToFront(name string) *Pages {
break break
} }
} }
p.refocus() if p.HasFocus() {
p.Focus(p.setFocus)
}
return p return p
} }
@ -186,7 +199,9 @@ func (p *Pages) SendToBack(name string) *Pages {
break break
} }
} }
p.refocus() if p.HasFocus() {
p.Focus(p.setFocus)
}
return p return p
} }
@ -214,25 +229,6 @@ func (p *Pages) Focus(delegate func(p Primitive)) {
} }
} }
// refocus sets the focus to the topmost visible page but only if we have focus.
func (p *Pages) refocus() {
var (
topItem Primitive
hasFocus bool
)
for _, page := range p.pages {
if page.Item.GetFocusable().HasFocus() {
hasFocus = true
}
if page.Visible {
topItem = page.Item
}
}
if hasFocus && p.setFocus != nil && topItem != nil {
p.setFocus(topItem)
}
}
// Draw draws this primitive onto the screen. // Draw draws this primitive onto the screen.
func (p *Pages) Draw(screen tcell.Screen) { func (p *Pages) Draw(screen tcell.Screen) {
for _, page := range p.pages { for _, page := range p.pages {