OrgGo/tcell
1
0
Fork 0
mirror of https://github.com/gdamore/tcell.git synced 2025-04-24 13:48:51 +08:00
Code Issues Projects Releases Wiki Activity

Remove redundant 'equal to' comparison in ViewPort.ValidateView methods. (#557)

Browse Source 
The 'equal to' comparisons in the `ViewPort.ValidateViewX()` and `ViewPort.ValidateViewY()` methods are not required as the `ViewPort`s corresponding `view` attributes will be set equal to the right operand if the conditional resolves as true. The current behaviour results in the `view` attributes being set unnecessarily if it already equals the limit.
This commit is contained in:
Chris Bradbury 2022-09-11 21:16:51 +01:00 committed by GitHub
parent a8322bf143
commit eef35d4cfc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
views/view.go
View File

@ -146,7 +146,7 @@ func (v *ViewPort) MakeVisible(x, y int) {
// ValidateViewY ensures that the Y offset of the view port is limited so that
// it cannot scroll away from the content.
func (v *ViewPort) ValidateViewY() {
if v.viewy >= v.limy-v.height {
if v.viewy > v.limy-v.height {
v.viewy = (v.limy - v.height)
}
if v.viewy < 0 {
@ -157,7 +157,7 @@ func (v *ViewPort) ValidateViewY() {
// ValidateViewX ensures that the X offset of the view port is limited so that
// it cannot scroll away from the content.
func (v *ViewPort) ValidateViewX() {
if v.viewx >= v.limx-v.width {
if v.viewx > v.limx-v.width {
v.viewx = (v.limx - v.width)
}
if v.viewx < 0 {