OrgGo/pocke.goevent
1
0
Fork 0
mirror of https://github.com/pocke/goevent.git synced 2025-04-24 13:48:55 +08:00
Code Issues Projects Releases Wiki Activity

DRY

Browse Source
This commit is contained in:
pocke 2015-01-08 22:20:49 +09:00
parent a72038414b
commit b16e211d60
1 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
pfs.go
View File

@ -51,26 +51,15 @@ func (p *PFS) Pub(args ...interface{}) bool {
}
func (p *PFS) Sub(f interface{}) error {
fn, err := p.checkFuncSignature(f)
if err != nil {
return err
}
p.lmu.Lock()
defer p.lmu.Unlock()
p.listeners = append(p.listeners, *fn)
fn := reflect.ValueOf(f)
if reflect.Func != fn.Kind() {
return fmt.Errorf("Argument should be a function")
}
if len(p.listeners) != 0 {
// TODO: check fn arguments
}
p.fmu.RLock()
if len(p.filters) != 0 {
// TODO: check fn arguments
}
p.fmu.RUnlock()
p.listeners = append(p.listeners, fn)
return nil
}
@ -79,29 +68,37 @@ func (p *PFS) Off() {
}
func (p *PFS) Filter(f interface{}) error {
fn, err := p.checkFuncSignature(f)
if err != nil {
return err
}
p.fmu.Lock()
defer p.fmu.Unlock()
p.filters = append(p.filters, *fn)
// TODO: DRY
return nil
}
func (p *PFS) checkFuncSignature(f interface{}) (*reflect.Value, error) {
fn := reflect.ValueOf(f)
if reflect.Func != fn.Kind() {
return fmt.Errorf("Argument should be a function")
if fn.Kind() != reflect.Func {
return nil, fmt.Errorf("Argument should be a function")
}
p.lmu.RLock()
defer p.lmu.RUnlock()
if len(p.listeners) != 0 {
// TODO: check fn arguments
}
p.lmu.RUnlock()
p.fmu.RLock()
defer p.fmu.RUnlock()
if len(p.filters) != 0 {
// TODO: check fn arguments
}
p.filters = append(p.filters, fn)
return nil
return &fn, nil
}
func (p *PFS) filtering(arguments []reflect.Value) bool {