OrgGo/hybridgroup.gobot
1
0
Fork 0
mirror of https://github.com/hybridgroup/gobot.git synced 2025-04-26 13:48:49 +08:00
Code Issues Projects Releases Wiki Activity

tests: refactor test interfaces out of implementations and into the tests where they belong

Browse Source 
Signed-off-by: deadprogram <ron@hybridgroup.com>
This commit is contained in:
deadprogram 2016-08-26 14:23:03 +02:00
parent 986cfaa3f3
commit a64f56d479
15 changed files with 47 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
platforms/audio/audio_adaptor.go
View File

@ -7,12 +7,8 @@ import (
"os"
"os/exec"
"path"
"github.com/hybridgroup/gobot"
)
var _ gobot.Adaptor = (*AudioAdaptor)(nil)
type AudioAdaptor struct {
name string
}

3
platforms/audio/audio_adaptor_test.go
View File

@ -5,9 +5,12 @@ import (
"os/exec"
"testing"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/gobottest"
)
var _ gobot.Adaptor = (*AudioAdaptor)(nil)
func TestAudioAdaptor(t *testing.T) {
a := NewAudioAdaptor("tester")

2
platforms/audio/audio_driver.go
View File

@ -7,8 +7,6 @@ import (
"time"
)
var _ gobot.Driver = (*AudioDriver)(nil)
type AudioDriver struct {
name string
connection gobot.Connection

3
platforms/audio/audio_driver_test.go
View File

@ -6,9 +6,12 @@ import (
"os/exec"
"testing"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/gobottest"
)
var _ gobot.Driver = (*AudioDriver)(nil)
func TestAudioDriver(t *testing.T) {
d := NewAudioDriver(NewAudioAdaptor("conn"), "dev", "../../examples/laser.mp3")

12
platforms/beaglebone/beaglebone_adaptor.go
View File

@ -10,21 +10,9 @@ import (
"strings"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/platforms/gpio"
"github.com/hybridgroup/gobot/platforms/i2c"
"github.com/hybridgroup/gobot/sysfs"
)
var _ gobot.Adaptor = (*BeagleboneAdaptor)(nil)
var _ gpio.DigitalReader = (*BeagleboneAdaptor)(nil)
var _ gpio.DigitalWriter = (*BeagleboneAdaptor)(nil)
var _ gpio.AnalogReader = (*BeagleboneAdaptor)(nil)
var _ gpio.PwmWriter = (*BeagleboneAdaptor)(nil)
var _ gpio.ServoWriter = (*BeagleboneAdaptor)(nil)
var _ i2c.I2c = (*BeagleboneAdaptor)(nil)
var slots = "/sys/devices/bone_capemgr.*"
var ocp = "/sys/devices/ocp.*"
var usrLed = "/sys/devices/ocp.3/gpio-leds.8/leds/beaglebone:green:"

13
platforms/beaglebone/beaglebone_adaptor_test.go
View File

@ -5,10 +5,23 @@ import (
"strings"
"testing"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/gobottest"
"github.com/hybridgroup/gobot/platforms/gpio"
"github.com/hybridgroup/gobot/platforms/i2c"
"github.com/hybridgroup/gobot/sysfs"
)
var _ gobot.Adaptor = (*BeagleboneAdaptor)(nil)
var _ gpio.DigitalReader = (*BeagleboneAdaptor)(nil)
var _ gpio.DigitalWriter = (*BeagleboneAdaptor)(nil)
var _ gpio.AnalogReader = (*BeagleboneAdaptor)(nil)
var _ gpio.PwmWriter = (*BeagleboneAdaptor)(nil)
var _ gpio.ServoWriter = (*BeagleboneAdaptor)(nil)
var _ i2c.I2c = (*BeagleboneAdaptor)(nil)
type NullReadWriteCloser struct {
contents []byte
}

3
platforms/ble/ble_client_adaptor_test.go
View File

@ -8,9 +8,6 @@ import (
func initTestBLEClientAdaptor() *BLEClientAdaptor {
a := NewBLEClientAdaptor("bot", "D7:99:5A:26:EC:38")
// a.connect = func(n *BLEAdaptor) (io.ReadWriteCloser, error) {
// return &NullReadWriteCloser{}, nil
// }
return a
}

10
platforms/chip/chip_adaptor.go
View File

@ -3,19 +3,9 @@ package chip
import (
"errors"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/platforms/gpio"
"github.com/hybridgroup/gobot/platforms/i2c"
"github.com/hybridgroup/gobot/sysfs"
)
var _ gobot.Adaptor = (*ChipAdaptor)(nil)
var _ gpio.DigitalReader = (*ChipAdaptor)(nil)
var _ gpio.DigitalWriter = (*ChipAdaptor)(nil)
var _ i2c.I2c = (*ChipAdaptor)(nil)
type ChipAdaptor struct {
name string
digitalPins map[int]sysfs.DigitalPin

10
platforms/chip/chip_adaptor_test.go
View File

@ -4,10 +4,20 @@ import (
"errors"
"testing"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/gobottest"
"github.com/hybridgroup/gobot/platforms/gpio"
"github.com/hybridgroup/gobot/platforms/i2c"
"github.com/hybridgroup/gobot/sysfs"
)
var _ gobot.Adaptor = (*ChipAdaptor)(nil)
var _ gpio.DigitalReader = (*ChipAdaptor)(nil)
var _ gpio.DigitalWriter = (*ChipAdaptor)(nil)
var _ i2c.I2c = (*ChipAdaptor)(nil)
type NullReadWriteCloser struct {
contents []byte
}

12
platforms/firmata/firmata_adaptor.go
View File

@ -7,21 +7,9 @@ import (
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/platforms/firmata/client"
"github.com/hybridgroup/gobot/platforms/gpio"
"github.com/hybridgroup/gobot/platforms/i2c"
"github.com/tarm/goserial"
)
var _ gobot.Adaptor = (*FirmataAdaptor)(nil)
var _ gpio.DigitalReader = (*FirmataAdaptor)(nil)
var _ gpio.DigitalWriter = (*FirmataAdaptor)(nil)
var _ gpio.AnalogReader = (*FirmataAdaptor)(nil)
var _ gpio.PwmWriter = (*FirmataAdaptor)(nil)
var _ gpio.ServoWriter = (*FirmataAdaptor)(nil)
var _ i2c.I2c = (*FirmataAdaptor)(nil)
type firmataBoard interface {
Connect(io.ReadWriteCloser) error
Disconnect() error

12
platforms/firmata/firmata_adaptor_test.go
View File

@ -12,8 +12,20 @@ import (
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/gobottest"
"github.com/hybridgroup/gobot/platforms/firmata/client"
"github.com/hybridgroup/gobot/platforms/gpio"
"github.com/hybridgroup/gobot/platforms/i2c"
)
var _ gobot.Adaptor = (*FirmataAdaptor)(nil)
var _ gpio.DigitalReader = (*FirmataAdaptor)(nil)
var _ gpio.DigitalWriter = (*FirmataAdaptor)(nil)
var _ gpio.AnalogReader = (*FirmataAdaptor)(nil)
var _ gpio.PwmWriter = (*FirmataAdaptor)(nil)
var _ gpio.ServoWriter = (*FirmataAdaptor)(nil)
var _ i2c.I2c = (*FirmataAdaptor)(nil)
type readWriteCloser struct{}
func (readWriteCloser) Write(p []byte) (int, error) {

3
platforms/joystick/joystick_adaptor.go
View File

@ -4,11 +4,8 @@ import (
"errors"
"github.com/veandco/go-sdl2/sdl"
"github.com/hybridgroup/gobot"
)
var _ gobot.Adaptor = (*JoystickAdaptor)(nil)
type joystick interface {
Close()
InstanceID() sdl.JoystickID

3
platforms/joystick/joystick_adaptor_test.go
View File

@ -4,9 +4,12 @@ import (
"errors"
"testing"
"github.com/hybridgroup/gobot"
"github.com/hybridgroup/gobot/gobottest"
)
var _ gobot.Adaptor = (*JoystickAdaptor)(nil)
func initTestJoystickAdaptor() *JoystickAdaptor {
a := NewJoystickAdaptor("bot")
a.connect = func(j *JoystickAdaptor) (err error) {

4
platforms/joystick/joystick_driver.go
View File

@ -6,12 +6,10 @@ import (
"io/ioutil"
"time"
"github.com/veandco/go-sdl2/sdl"
"github.com/hybridgroup/gobot"
"github.com/veandco/go-sdl2/sdl"
)
var _ gobot.Driver = (*JoystickDriver)(nil)
// JoystickDriver represents a joystick
type JoystickDriver struct {
name string

2
platforms/joystick/joystick_driver_test.go
View File

@ -9,6 +9,8 @@ import (
"github.com/veandco/go-sdl2/sdl"
)
var _ gobot.Driver = (*JoystickDriver)(nil)
func initTestJoystickDriver() *JoystickDriver {
a := NewJoystickAdaptor("bot")
a.connect = func(j *JoystickAdaptor) (err error) {