OrgGo/hybridgroup.gobot
1
0
Fork 0
mirror of https://github.com/hybridgroup/gobot.git synced 2025-05-11 19:29:20 +08:00
Code Issues Projects Releases Wiki Activity

minidrone: remove unneeded code, increase test coverage

Browse Source 
Signed-off-by: deadprogram <ron@hybridgroup.com>
This commit is contained in:
deadprogram 2017-05-13 13:45:24 +02:00
parent 227be18be7
commit 870ea0fc99
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
platforms/parrot/minidrone/minidrone_driver.go
View File

@ -209,10 +209,6 @@ func (b *Driver) GenerateAllStates() (err error) {
b.stepsfa0b++ b.stepsfa0b++
buf := []byte{0x04, byte(b.stepsfa0b), 0x00, 0x04, 0x01, 0x00, 0x32, 0x30, 0x31, 0x34, 0x2D, 0x31, 0x30, 0x2D, 0x32, 0x38, 0x00} buf := []byte{0x04, byte(b.stepsfa0b), 0x00, 0x04, 0x01, 0x00, 0x32, 0x30, 0x31, 0x34, 0x2D, 0x31, 0x30, 0x2D, 0x32, 0x38, 0x00}
err = b.adaptor().WriteCharacteristic(commandCharacteristic, buf) err = b.adaptor().WriteCharacteristic(commandCharacteristic, buf)
if err != nil {
fmt.Println("GenerateAllStates error:", err)
return err
}
return return
} }
@ -222,10 +218,6 @@ func (b *Driver) TakeOff() (err error) {
b.stepsfa0b++ b.stepsfa0b++
buf := []byte{0x02, byte(b.stepsfa0b) & 0xff, 0x02, 0x00, 0x01, 0x00} buf := []byte{0x02, byte(b.stepsfa0b) & 0xff, 0x02, 0x00, 0x01, 0x00}
err = b.adaptor().WriteCharacteristic(commandCharacteristic, buf) err = b.adaptor().WriteCharacteristic(commandCharacteristic, buf)
if err != nil {
fmt.Println("takeoff error:", err)
return err
}
return return
} }

13
platforms/parrot/minidrone/minidrone_driver_test.go
View File

@ -52,6 +52,13 @@ func TestMinidroneUp(t *testing.T) {
gobottest.Assert(t, d.Up(25), nil) gobottest.Assert(t, d.Up(25), nil)
} }
func TestMinidroneUpTooFar(t *testing.T) {
d := initTestMinidroneDriver()
gobottest.Assert(t, d.Start(), nil)
gobottest.Assert(t, d.Up(125), nil)
gobottest.Assert(t, d.Up(-50), nil)
}
func TestMinidroneDown(t *testing.T) { func TestMinidroneDown(t *testing.T) {
d := initTestMinidroneDriver() d := initTestMinidroneDriver()
gobottest.Assert(t, d.Start(), nil) gobottest.Assert(t, d.Start(), nil)
@ -94,6 +101,12 @@ func TestMinidroneCounterClockwise(t *testing.T) {
gobottest.Assert(t, d.CounterClockwise(25), nil) gobottest.Assert(t, d.CounterClockwise(25), nil)
} }
func TestMinidroneStop(t *testing.T) {
d := initTestMinidroneDriver()
gobottest.Assert(t, d.Start(), nil)
gobottest.Assert(t, d.Stop(), nil)
}
func TestMinidroneStartStopRecording(t *testing.T) { func TestMinidroneStartStopRecording(t *testing.T) {
d := initTestMinidroneDriver() d := initTestMinidroneDriver()
gobottest.Assert(t, d.Start(), nil) gobottest.Assert(t, d.Start(), nil)