Merge remote-tracking branch 'upstream/master'

This commit is contained in:
tramhao 2021-03-04 13:44:41 +08:00
commit 2dab0b4c5c
11 changed files with 9 additions and 18 deletions

View File

@ -18,7 +18,7 @@ test:
format:
@echo === FORMATTING ===
go fmt *.go
go fmt ./...
$(BIN_DIR):
mkdir -p $@

View File

@ -6,7 +6,6 @@ import (
"github.com/stretchr/testify/assert"
)
func TestGetFn(t *testing.T) {
c := newCommand()

View File

@ -7,7 +7,7 @@ import (
)
func TestAddHook(t *testing.T) {
h := NewEventHook()
h.AddHook("a", nil)
@ -31,7 +31,7 @@ func TestRunHooks(t *testing.T) {
h := NewEventHook()
x := 0
for i := 0; i < 100; i ++ {
for i := 0; i < 100; i++ {
h.AddHook("sample", func() {
x++
})

View File

@ -69,7 +69,7 @@ func (_ *Invidious) GetSuggestions(prefix string) ([]string, error) {
return suggestions, nil
}
// GetTrendingMusic fetch music trending based on region.
// GetTrendingMusic fetch music trending based on region.
// Region (ISO 3166 country code) can be provided in the argument.
func (i *Invidious) GetTrendingMusic(region string) ([]YoutubeVideo, error) {
@ -83,7 +83,7 @@ func (i *Invidious) GetTrendingMusic(region string) ([]YoutubeVideo, error) {
return nil, err
}
return yt, nil
return yt, nil
}
// getRequest is a helper function that simplifies GET request and parsing the

View File

@ -218,7 +218,6 @@ func (p *Player) Skip() {
p.execSongFinish(p.currentSong)
}
// GetPosition returns the current position of audio file.
func (p *Player) GetPosition() time.Duration {

View File

@ -6,8 +6,8 @@ import (
"path/filepath"
"testing"
"github.com/rivo/tview"
"github.com/issadarkthing/gomu/player"
"github.com/rivo/tview"
)
// Prepares for test

View File

@ -219,7 +219,7 @@ func (q *Queue) saveQueue(isQuit bool) error {
currentSongInQueue = true
}
}
if !currentSongInQueue {
if !currentSongInQueue && len(q.items) != 0 {
hashed := sha1Hex(getName(currentSongPath))
content.WriteString(hashed + "\n")
}

View File

@ -94,7 +94,6 @@ func TestPushFront(t *testing.T) {
gomu.playlist.addAllToQueue(rapPlaylist)
selSong, err := gomu.queue.deleteItem(2)
if err != nil {
t.Error(err)

View File

@ -470,15 +470,10 @@ func start(application *tview.Application, args Args) {
init := false
gomu.app.SetAfterDrawFunc(func(_ tcell.Screen) {
if !init {
if !init && !gomu.player.IsRunning() {
gomu.playingBar.setDefault()
init = true
}
if gomu.player.IsRunning() {
gomu.playingBar.setSongTitle(gomu.player.GetCurrentSong().Name())
} else {
gomu.playingBar.setDefault()
}
})
go populateAudioLength(gomu.playlist.GetRoot())

View File

@ -8,7 +8,6 @@ import (
"github.com/stretchr/testify/assert"
)
func TestSetupHooks(t *testing.T) {
gomu := newGomu()

View File

@ -119,7 +119,7 @@ func TestEmbedLyric(t *testing.T) {
}
f.Close()
defer func(){
defer func() {
err := os.Remove(testFile)
if err != nil {
t.Error(err)