1
0
mirror of https://github.com/mainflux/mainflux.git synced 2025-04-24 13:48:49 +08:00
Manuel Imperiale d2fc379e3f NOISSUE - Fix Postgres logs in Things service (#734)
* NOISSUE - Fix Postgres logs in Things service

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix uuid package

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
2019-05-10 18:55:13 +02:00

428 lines
9.2 KiB
Go

//
// Copyright (c) 2018
// Mainflux
//
// SPDX-License-Identifier: Apache-2.0
//
package postgres_test
import (
"fmt"
"testing"
"github.com/stretchr/testify/require"
"github.com/mainflux/mainflux/things"
"github.com/mainflux/mainflux/things/postgres"
"github.com/mainflux/mainflux/things/uuid"
"github.com/stretchr/testify/assert"
)
func TestThingSave(t *testing.T) {
email := "thing-save@example.com"
thingRepo := postgres.NewThingRepository(db)
thing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
cases := []struct {
desc string
thing things.Thing
err error
}{
{
desc: "create new thing",
thing: thing,
err: nil,
},
{
desc: "create invalid thing",
thing: things.Thing{
ID: "invalid",
Owner: email,
Key: uuid.New().ID(),
},
err: things.ErrMalformedEntity,
},
{
desc: "create thing with conflicting key",
thing: thing,
err: things.ErrConflict,
},
}
for _, tc := range cases {
_, err := thingRepo.Save(tc.thing)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected %s got %s\n", tc.desc, tc.err, err))
}
}
func TestThingUpdate(t *testing.T) {
email := "thing-update@example.com"
thingRepo := postgres.NewThingRepository(db)
thing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
id, _ := thingRepo.Save(thing)
thing.ID = id
cases := []struct {
desc string
thing things.Thing
err error
}{
{
desc: "update existing thing",
thing: thing,
err: nil,
},
{
desc: "update non-existing thing with existing user",
thing: things.Thing{
ID: uuid.New().ID(),
Owner: email,
},
err: things.ErrNotFound,
},
{
desc: "update existing thing ID with non-existing user",
thing: things.Thing{
ID: id,
Owner: wrongValue,
},
err: things.ErrNotFound,
},
{
desc: "update non-existing thing with non-existing user",
thing: things.Thing{
ID: uuid.New().ID(),
Owner: wrongValue,
},
err: things.ErrNotFound,
},
}
for _, tc := range cases {
err := thingRepo.Update(tc.thing)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected %s got %s\n", tc.desc, tc.err, err))
}
}
func TestUpdateKey(t *testing.T) {
email := "thing-update=key@example.com"
newKey := "new-key"
thingRepo := postgres.NewThingRepository(db)
existingThing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
existingID, _ := thingRepo.Save(existingThing)
existingThing.ID = existingID
thing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
id, _ := thingRepo.Save(thing)
thing.ID = id
cases := []struct {
desc string
owner string
id string
key string
err error
}{
{
desc: "update key of an existing thing",
owner: thing.Owner,
id: thing.ID,
key: newKey,
err: nil,
},
{
desc: "update key of a non-existing thing with existing user",
owner: thing.Owner,
id: uuid.New().ID(),
key: newKey,
err: things.ErrNotFound,
},
{
desc: "update key of an existing thing with non-existing user",
owner: wrongValue,
id: thing.ID,
key: newKey,
err: things.ErrNotFound,
},
{
desc: "update key of a non-existing thing with non-existing user",
owner: wrongValue,
id: uuid.New().ID(),
key: newKey,
err: things.ErrNotFound,
},
{
desc: "update key with existing key value",
owner: thing.Owner,
id: thing.ID,
key: existingThing.Key,
err: things.ErrConflict,
},
}
for _, tc := range cases {
err := thingRepo.UpdateKey(tc.owner, tc.id, tc.key)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected %s got %s\n", tc.desc, tc.err, err))
}
}
func TestSingleThingRetrieval(t *testing.T) {
email := "thing-single-retrieval@example.com"
thingRepo := postgres.NewThingRepository(db)
thing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
id, _ := thingRepo.Save(thing)
thing.ID = id
cases := map[string]struct {
owner string
ID string
err error
}{
"retrieve thing with existing user": {
owner: thing.Owner,
ID: thing.ID,
err: nil,
},
"retrieve non-existing thing with existing user": {
owner: thing.Owner,
ID: uuid.New().ID(),
err: things.ErrNotFound,
},
"retrieve thing with non-existing owner": {
owner: wrongValue,
ID: thing.ID,
err: things.ErrNotFound,
},
"retrieve thing with malformed ID": {
owner: thing.Owner,
ID: wrongValue,
err: things.ErrNotFound,
},
}
for desc, tc := range cases {
_, err := thingRepo.RetrieveByID(tc.owner, tc.ID)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected %s got %s\n", desc, tc.err, err))
}
}
func TestThingRetrieveByKey(t *testing.T) {
email := "thing-retrieved-by-key@example.com"
thingRepo := postgres.NewThingRepository(db)
thing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
id, _ := thingRepo.Save(thing)
thing.ID = id
cases := map[string]struct {
key string
ID string
err error
}{
"retrieve existing thing by key": {
key: thing.Key,
ID: thing.ID,
err: nil,
},
"retrieve non-existent thing by key": {
key: wrongValue,
ID: "",
err: things.ErrNotFound,
},
}
for desc, tc := range cases {
id, err := thingRepo.RetrieveByKey(tc.key)
assert.Equal(t, tc.ID, id, fmt.Sprintf("%s: expected %s got %s\n", desc, tc.ID, id))
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected %s got %s\n", desc, tc.err, err))
}
}
func TestMultiThingRetrieval(t *testing.T) {
email := "thing-multi-retrieval@example.com"
idp := uuid.New()
thingRepo := postgres.NewThingRepository(db)
n := uint64(10)
for i := uint64(0); i < n; i++ {
t := things.Thing{
ID: idp.ID(),
Owner: email,
Key: idp.ID(),
}
thingRepo.Save(t)
}
cases := map[string]struct {
owner string
offset uint64
limit uint64
size uint64
}{
"retrieve all things with existing owner": {
owner: email,
offset: 0,
limit: n,
size: n,
},
"retrieve subset of things with existing owner": {
owner: email,
offset: n / 2,
limit: n,
size: n / 2,
},
"retrieve things with non-existing owner": {
owner: wrongValue,
offset: 0,
limit: n,
size: 0,
},
}
for desc, tc := range cases {
page, err := thingRepo.RetrieveAll(tc.owner, tc.offset, tc.limit)
size := uint64(len(page.Things))
assert.Equal(t, tc.size, size, fmt.Sprintf("%s: expected %d got %d\n", desc, tc.size, size))
assert.Nil(t, err, fmt.Sprintf("%s: expected no error got %d\n", desc, err))
}
}
func TestMultiThingRetrievalByChannel(t *testing.T) {
email := "thing-multi-retrieval-by-channel@example.com"
idp := uuid.New()
thingRepo := postgres.NewThingRepository(db)
channelRepo := postgres.NewChannelRepository(db)
n := uint64(10)
cid, err := channelRepo.Save(things.Channel{
ID: idp.ID(),
Owner: email,
})
require.Nil(t, err, fmt.Sprintf("unexpected error: %s", err))
for i := uint64(0); i < n; i++ {
th := things.Thing{
ID: idp.ID(),
Owner: email,
Key: idp.ID(),
}
tid, err := thingRepo.Save(th)
require.Nil(t, err, fmt.Sprintf("unexpected error: %s", err))
err = channelRepo.Connect(email, cid, tid)
require.Nil(t, err, fmt.Sprintf("unexpected error: %s", err))
}
cases := map[string]struct {
owner string
channel string
offset uint64
limit uint64
size uint64
err error
}{
"retrieve all things by channel with existing owner": {
owner: email,
channel: cid,
offset: 0,
limit: n,
size: n,
},
"retrieve subset of things by channel with existing owner": {
owner: email,
channel: cid,
offset: n / 2,
limit: n,
size: n / 2,
},
"retrieve things by channel with non-existing owner": {
owner: wrongValue,
channel: cid,
offset: 0,
limit: n,
size: 0,
},
"retrieve things by non-existent channel": {
owner: email,
channel: uuid.New().ID(),
offset: 0,
limit: n,
size: 0,
},
"retrieve things with malformed UUID": {
owner: email,
channel: wrongValue,
offset: 0,
limit: n,
size: 0,
err: things.ErrNotFound,
},
}
for desc, tc := range cases {
page, err := thingRepo.RetrieveByChannel(tc.owner, tc.channel, tc.offset, tc.limit)
size := uint64(len(page.Things))
assert.Equal(t, tc.size, size, fmt.Sprintf("%s: expected %d got %d\n", desc, tc.size, size))
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected no error got %d\n", desc, err))
}
}
func TestThingRemoval(t *testing.T) {
email := "thing-removal@example.com"
thingRepo := postgres.NewThingRepository(db)
thing := things.Thing{
ID: uuid.New().ID(),
Owner: email,
Key: uuid.New().ID(),
}
id, _ := thingRepo.Save(thing)
thing.ID = id
// show that the removal works the same for both existing and non-existing
// (removed) thing
for i := 0; i < 2; i++ {
err := thingRepo.Remove(email, thing.ID)
require.Nil(t, err, fmt.Sprintf("#%d: failed to remove thing due to: %s", i, err))
_, err = thingRepo.RetrieveByID(email, thing.ID)
require.Equal(t, things.ErrNotFound, err, fmt.Sprintf("#%d: expected %s got %s", i, things.ErrNotFound, err))
}
}