mirror of
https://github.com/mainflux/mainflux.git
synced 2025-04-29 13:49:28 +08:00

* Fix linting errors Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * feat(linters): add ineffassign linter This commit adds the `ineffassign` linter to the project's `.golangci.yml` configuration file. The `ineffassign` linter helps identify and flag assignments to variables that are never used, helping to improve code quality and maintainability. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * Add extra linters Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * feat(golangci): Add header check - Added goheader check to ensure all files have license headers - Added build tags for "nats" in the .golangci.yml file to include the necessary dependencies for the "nats" package during the build process. - Also, increased the maximum number of issues per linter and the maximum number of same issues reported by the linter to improve the code quality analysis. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * feat(.golangci.yml): Add new linters Add the following new linters to the .golangci.yml configuration file: - asasalint - asciicheck - bidichk - contextcheck - decorder - dogsled - errchkjson - errname - execinquery - exportloopref - ginkgolinter - gocheckcompilerdirectives These linters will help improve code quality and catch potential issues during the code review process. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> --------- Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
381 lines
11 KiB
Go
381 lines
11 KiB
Go
// Copyright (c) Mainflux
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package grpc_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/mainflux/mainflux"
|
|
"github.com/mainflux/mainflux/auth"
|
|
grpcapi "github.com/mainflux/mainflux/auth/api/grpc"
|
|
"github.com/mainflux/mainflux/auth/jwt"
|
|
"github.com/mainflux/mainflux/auth/mocks"
|
|
"github.com/mainflux/mainflux/pkg/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/credentials/insecure"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
const (
|
|
port = 8081
|
|
secret = "secret"
|
|
email = "test@example.com"
|
|
id = "testID"
|
|
thingsType = "things"
|
|
usersType = "users"
|
|
description = "Description"
|
|
|
|
authoritiesObj = "authorities"
|
|
memberRelation = "member"
|
|
loginDuration = 30 * time.Minute
|
|
refreshDuration = 24 * time.Hour
|
|
)
|
|
|
|
var svc auth.Service
|
|
|
|
func newService() auth.Service {
|
|
krepo := new(mocks.Keys)
|
|
prepo := new(mocks.PolicyAgent)
|
|
idProvider := uuid.NewMock()
|
|
|
|
t := jwt.New([]byte(secret))
|
|
|
|
return auth.New(krepo, idProvider, t, prepo, loginDuration, refreshDuration)
|
|
}
|
|
|
|
func startGRPCServer(svc auth.Service, port int) {
|
|
listener, _ := net.Listen("tcp", fmt.Sprintf(":%d", port))
|
|
server := grpc.NewServer()
|
|
mainflux.RegisterAuthServiceServer(server, grpcapi.NewServer(svc))
|
|
go func() {
|
|
if err := server.Serve(listener); err != nil {
|
|
panic(fmt.Sprintf("failed to serve: %s", err))
|
|
}
|
|
}()
|
|
}
|
|
|
|
func TestIssue(t *testing.T) {
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, _ := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
client := grpcapi.NewClient(conn, time.Second)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
id string
|
|
email string
|
|
kind auth.KeyType
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "issue for user with valid token",
|
|
id: id,
|
|
email: email,
|
|
kind: auth.AccessKey,
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "issue recovery key",
|
|
id: id,
|
|
email: email,
|
|
kind: auth.RecoveryKey,
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "issue API key unauthenticated",
|
|
id: id,
|
|
email: email,
|
|
kind: auth.APIKey,
|
|
err: nil,
|
|
code: codes.Unauthenticated,
|
|
},
|
|
{
|
|
desc: "issue for invalid key type",
|
|
id: id,
|
|
email: email,
|
|
kind: 32,
|
|
err: status.Error(codes.InvalidArgument, "received invalid token request"),
|
|
code: codes.InvalidArgument,
|
|
},
|
|
{
|
|
desc: "issue for user that exist",
|
|
id: "",
|
|
email: "",
|
|
kind: auth.APIKey,
|
|
err: status.Error(codes.Unauthenticated, "unauthenticated access"),
|
|
code: codes.Unauthenticated,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
_, err := client.Issue(context.Background(), &mainflux.IssueReq{Id: tc.id, Type: uint32(tc.kind)})
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestIdentify(t *testing.T) {
|
|
loginToken, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.AccessKey, IssuedAt: time.Now(), Subject: id})
|
|
assert.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
recoveryToken, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.RecoveryKey, IssuedAt: time.Now(), Subject: id})
|
|
assert.Nil(t, err, fmt.Sprintf("Issuing recovery key expected to succeed: %s", err))
|
|
|
|
apiToken, err := svc.Issue(context.Background(), loginToken.AccessToken, auth.Key{Type: auth.APIKey, IssuedAt: time.Now(), ExpiresAt: time.Now().Add(time.Minute), Subject: id})
|
|
assert.Nil(t, err, fmt.Sprintf("Issuing API key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, _ := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
client := grpcapi.NewClient(conn, time.Second)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
idt *mainflux.IdentityRes
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "identify user with user token",
|
|
token: loginToken.AccessToken,
|
|
idt: &mainflux.IdentityRes{Id: id},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "identify user with recovery token",
|
|
token: recoveryToken.AccessToken,
|
|
idt: &mainflux.IdentityRes{Id: id},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "identify user with API token",
|
|
token: apiToken.AccessToken,
|
|
idt: &mainflux.IdentityRes{Id: id},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "identify user with invalid user token",
|
|
token: "invalid",
|
|
idt: &mainflux.IdentityRes{},
|
|
err: status.Error(codes.Unauthenticated, "unauthenticated access"),
|
|
code: codes.Unauthenticated,
|
|
},
|
|
{
|
|
desc: "identify user with empty token",
|
|
token: "",
|
|
idt: &mainflux.IdentityRes{},
|
|
err: status.Error(codes.InvalidArgument, "received invalid token request"),
|
|
code: codes.Unauthenticated,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
idt, err := client.Identify(context.Background(), &mainflux.IdentityReq{Token: tc.token})
|
|
if idt != nil {
|
|
assert.Equal(t, tc.idt, idt, fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.idt, idt))
|
|
}
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestAuthorize(t *testing.T) {
|
|
token, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.AccessKey, IssuedAt: time.Now(), Subject: id})
|
|
assert.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, _ := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
client := grpcapi.NewClient(conn, time.Second)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
subject string
|
|
object string
|
|
relation string
|
|
ar *mainflux.AuthorizeRes
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "authorize user with authorized token",
|
|
token: token.AccessToken,
|
|
subject: id,
|
|
object: authoritiesObj,
|
|
relation: memberRelation,
|
|
ar: &mainflux.AuthorizeRes{Authorized: true},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "authorize user with unauthorized relation",
|
|
token: token.AccessToken,
|
|
subject: id,
|
|
object: authoritiesObj,
|
|
relation: "unauthorizedRelation",
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.PermissionDenied,
|
|
},
|
|
{
|
|
desc: "authorize user with unauthorized object",
|
|
token: token.AccessToken,
|
|
subject: id,
|
|
object: "unauthorizedobject",
|
|
relation: memberRelation,
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.PermissionDenied,
|
|
},
|
|
{
|
|
desc: "authorize user with unauthorized subject",
|
|
token: token.AccessToken,
|
|
subject: "unauthorizedSubject",
|
|
object: authoritiesObj,
|
|
relation: memberRelation,
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.PermissionDenied,
|
|
},
|
|
{
|
|
desc: "authorize user with invalid ACL",
|
|
token: token.AccessToken,
|
|
subject: "",
|
|
object: "",
|
|
relation: "",
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.InvalidArgument,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
ar, err := client.Authorize(context.Background(), &mainflux.AuthorizeReq{Subject: tc.subject, Object: tc.object, Relation: tc.relation})
|
|
if ar != nil {
|
|
assert.Equal(t, tc.ar, ar, fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.ar, ar))
|
|
}
|
|
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestAddPolicy(t *testing.T) {
|
|
token, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.AccessKey, IssuedAt: time.Now(), Subject: id})
|
|
assert.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, _ := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
client := grpcapi.NewClient(conn, time.Second)
|
|
|
|
groupAdminObj := "groupadmin"
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
subject string
|
|
object string
|
|
relation string
|
|
ar *mainflux.AddPolicyRes
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "add groupadmin policy to user",
|
|
token: token.AccessToken,
|
|
subject: id,
|
|
object: groupAdminObj,
|
|
relation: memberRelation,
|
|
ar: &mainflux.AddPolicyRes{Authorized: true},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "add policy to user with invalid ACL",
|
|
token: token.AccessToken,
|
|
subject: "",
|
|
object: "",
|
|
relation: "",
|
|
ar: &mainflux.AddPolicyRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.InvalidArgument,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
apr, err := client.AddPolicy(context.Background(), &mainflux.AddPolicyReq{Subject: tc.subject, Object: tc.object, Relation: tc.relation})
|
|
if apr != nil {
|
|
assert.Equal(t, tc.ar, apr, fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.ar, apr))
|
|
}
|
|
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestDeletePolicy(t *testing.T) {
|
|
token, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.AccessKey, IssuedAt: time.Now(), Subject: id})
|
|
assert.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, _ := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
client := grpcapi.NewClient(conn, time.Second)
|
|
|
|
readRelation := "read"
|
|
thingID := "thing"
|
|
|
|
apr, err := client.AddPolicy(context.Background(), &mainflux.AddPolicyReq{Subject: id, Object: thingID, Permission: readRelation})
|
|
assert.Nil(t, err, fmt.Sprintf("Adding read policy to user expected to succeed: %s", err))
|
|
assert.True(t, apr.GetAuthorized(), fmt.Sprintf("Adding read policy expected to make user authorized, expected %v got %v", true, apr.GetAuthorized()))
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
subject string
|
|
object string
|
|
relation string
|
|
dpr *mainflux.DeletePolicyRes
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "delete valid policy",
|
|
token: token.AccessToken,
|
|
subject: id,
|
|
object: thingID,
|
|
relation: readRelation,
|
|
dpr: &mainflux.DeletePolicyRes{Deleted: true},
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "delete invalid policy",
|
|
token: token.AccessToken,
|
|
subject: "",
|
|
object: "",
|
|
relation: "",
|
|
dpr: &mainflux.DeletePolicyRes{Deleted: false},
|
|
code: codes.InvalidArgument,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
dpr, err := client.DeletePolicy(context.Background(), &mainflux.DeletePolicyReq{Subject: tc.subject, Object: tc.object, Relation: tc.relation})
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
assert.Equal(t, tc.dpr.GetDeleted(), dpr.GetDeleted(), fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.dpr.GetDeleted(), dpr.GetDeleted()))
|
|
}
|
|
}
|