mirror of
https://github.com/mainflux/mainflux.git
synced 2025-04-29 13:49:28 +08:00

* things, twins, and logger lint fixed Signed-off-by: aryan <aryangodara03@gmail.com> * all services updated, auth jwt not working, ineffectual assignment issue Signed-off-by: aryan <aryangodara03@gmail.com> * handle error from grpc server in endpointtest Signed-off-by: aryan <aryangodara03@gmail.com> * temp commit, auth/jwt needs to be resolved Signed-off-by: aryan <aryangodara03@gmail.com> * revert back to jwt v4 temporarily Signed-off-by: aryan <aryangodara03@gmail.com> * updated jwt tokenizer Signed-off-by: aryan <aryangodara03@gmail.com> * resolve EOF error for httptest requests Signed-off-by: aryan <aryangodara03@gmail.com> * fix auth jwt, update to registeredclaims Signed-off-by: aryan <aryangodara03@gmail.com> * fix ineffective assignment, auth/api/grpc endpoint failing Signed-off-by: aryan <aryangodara03@gmail.com> * temp commit, remove later Signed-off-by: aryan <aryangodara03@gmail.com> * fix grpc server setup Signed-off-by: aryan <aryangodara03@gmail.com> * resolve golangci tests, remove debug statements Signed-off-by: aryan <aryangodara03@gmail.com> * update golangci version and modify linters used Signed-off-by: aryan <aryangodara03@gmail.com> * fix failing tests Signed-off-by: aryan <aryangodara03@gmail.com> * fix grpc server for setup tests Signed-off-by: aryan <aryangodara03@gmail.com> * fix logging and errors inlined Signed-off-by: aryan <aryangodara03@gmail.com> * fix remarks, update grpc setup_test Signed-off-by: aryan <aryangodara03@gmail.com> * fix setup_test Signed-off-by: aryan <aryangodara03@gmail.com> * update setup_test grpc Signed-off-by: aryan <aryangodara03@gmail.com> * fix data race Signed-off-by: aryan <aryangodara03@gmail.com> * update setup_test grpc Signed-off-by: aryan <aryangodara03@gmail.com> * fix grpc setup down to single simple function Signed-off-by: aryan <aryangodara03@gmail.com> * fix linting issues Signed-off-by: aryan <aryangodara03@gmail.com> * resolve pr comments Signed-off-by: aryan <aryangodara03@gmail.com> * fix tests, handle returned errors, go mod tidy vendor Signed-off-by: aryan <aryangodara03@gmail.com> * fix errors from new linters Signed-off-by: aryan <aryangodara03@gmail.com> --------- Signed-off-by: aryan <aryangodara03@gmail.com>
454 lines
14 KiB
Go
454 lines
14 KiB
Go
// Copyright (c) Mainflux
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package grpc_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/mainflux/mainflux"
|
|
"github.com/mainflux/mainflux/auth"
|
|
grpcapi "github.com/mainflux/mainflux/auth/api/grpc"
|
|
"github.com/mainflux/mainflux/pkg/uuid"
|
|
"github.com/opentracing/opentracing-go/mocktracer"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/credentials/insecure"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
const (
|
|
port = 7001
|
|
secret = "secret"
|
|
email = "test@example.com"
|
|
id = "testID"
|
|
thingsType = "things"
|
|
usersType = "users"
|
|
description = "Description"
|
|
|
|
numOfThings = 5
|
|
numOfUsers = 5
|
|
|
|
authoritiesObj = "authorities"
|
|
memberRelation = "member"
|
|
loginDuration = 30 * time.Minute
|
|
)
|
|
|
|
var svc auth.Service
|
|
|
|
func TestIssue(t *testing.T) {
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, err := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
require.Nil(t, err, fmt.Sprintf("got unexpected error while creating client connection: %s", err))
|
|
|
|
client := grpcapi.NewClient(mocktracer.New(), conn, time.Second)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
id string
|
|
email string
|
|
kind uint32
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "issue for user with valid token",
|
|
id: id,
|
|
email: email,
|
|
kind: auth.LoginKey,
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "issue recovery key",
|
|
id: id,
|
|
email: email,
|
|
kind: auth.RecoveryKey,
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "issue API key unauthenticated",
|
|
id: id,
|
|
email: email,
|
|
kind: auth.APIKey,
|
|
err: nil,
|
|
code: codes.Unauthenticated,
|
|
},
|
|
{
|
|
desc: "issue for invalid key type",
|
|
id: id,
|
|
email: email,
|
|
kind: 32,
|
|
err: status.Error(codes.InvalidArgument, "received invalid token request"),
|
|
code: codes.InvalidArgument,
|
|
},
|
|
{
|
|
desc: "issue for user that exist",
|
|
id: "",
|
|
email: "",
|
|
kind: auth.APIKey,
|
|
err: status.Error(codes.Unauthenticated, "unauthenticated access"),
|
|
code: codes.Unauthenticated,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
_, err := client.Issue(context.Background(), &mainflux.IssueReq{Id: tc.id, Email: tc.email, Type: tc.kind})
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestIdentify(t *testing.T) {
|
|
_, loginSecret, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.LoginKey, IssuedAt: time.Now(), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
_, recoverySecret, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.RecoveryKey, IssuedAt: time.Now(), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing recovery key expected to succeed: %s", err))
|
|
|
|
_, apiSecret, err := svc.Issue(context.Background(), loginSecret, auth.Key{Type: auth.APIKey, IssuedAt: time.Now(), ExpiresAt: time.Now().Add(time.Minute), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing API key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, err := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
require.Nil(t, err, fmt.Sprintf("got unexpected error while creating client connection: %s", err))
|
|
|
|
client := grpcapi.NewClient(mocktracer.New(), conn, time.Second)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
idt *mainflux.UserIdentity
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "identify user with user token",
|
|
token: loginSecret,
|
|
idt: &mainflux.UserIdentity{Email: email, Id: id},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "identify user with recovery token",
|
|
token: recoverySecret,
|
|
idt: &mainflux.UserIdentity{Email: email, Id: id},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "identify user with API token",
|
|
token: apiSecret,
|
|
idt: &mainflux.UserIdentity{Email: email, Id: id},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "identify user with invalid user token",
|
|
token: "invalid",
|
|
idt: &mainflux.UserIdentity{},
|
|
err: status.Error(codes.Unauthenticated, "unauthenticated access"),
|
|
code: codes.Unauthenticated,
|
|
},
|
|
{
|
|
desc: "identify user with empty token",
|
|
token: "",
|
|
idt: &mainflux.UserIdentity{},
|
|
err: status.Error(codes.InvalidArgument, "received invalid token request"),
|
|
code: codes.Unauthenticated,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
idt, err := client.Identify(context.Background(), &mainflux.Token{Value: tc.token})
|
|
if idt != nil {
|
|
assert.Equal(t, tc.idt, idt, fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.idt, idt))
|
|
}
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestAuthorize(t *testing.T) {
|
|
_, loginSecret, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.LoginKey, IssuedAt: time.Now(), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, err := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
require.Nil(t, err, fmt.Sprintf("got unexpected error while creating client connection: %s", err))
|
|
|
|
client := grpcapi.NewClient(mocktracer.New(), conn, time.Second)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
subject string
|
|
object string
|
|
relation string
|
|
ar *mainflux.AuthorizeRes
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "authorize user with authorized token",
|
|
token: loginSecret,
|
|
subject: id,
|
|
object: authoritiesObj,
|
|
relation: memberRelation,
|
|
ar: &mainflux.AuthorizeRes{Authorized: true},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "authorize user with unauthorized relation",
|
|
token: loginSecret,
|
|
subject: id,
|
|
object: authoritiesObj,
|
|
relation: "unauthorizedRelation",
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.PermissionDenied,
|
|
},
|
|
{
|
|
desc: "authorize user with unauthorized object",
|
|
token: loginSecret,
|
|
subject: id,
|
|
object: "unauthorizedobject",
|
|
relation: memberRelation,
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.PermissionDenied,
|
|
},
|
|
{
|
|
desc: "authorize user with unauthorized subject",
|
|
token: loginSecret,
|
|
subject: "unauthorizedSubject",
|
|
object: authoritiesObj,
|
|
relation: memberRelation,
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.PermissionDenied,
|
|
},
|
|
{
|
|
desc: "authorize user with invalid ACL",
|
|
token: loginSecret,
|
|
subject: "",
|
|
object: "",
|
|
relation: "",
|
|
ar: &mainflux.AuthorizeRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.InvalidArgument,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
ar, err := client.Authorize(context.Background(), &mainflux.AuthorizeReq{Sub: tc.subject, Obj: tc.object, Act: tc.relation})
|
|
if ar != nil {
|
|
assert.Equal(t, tc.ar, ar, fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.ar, ar))
|
|
}
|
|
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestAddPolicy(t *testing.T) {
|
|
_, loginSecret, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.LoginKey, IssuedAt: time.Now(), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, err := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
require.Nil(t, err, fmt.Sprintf("got unexpected error while creating client connection: %s", err))
|
|
|
|
client := grpcapi.NewClient(mocktracer.New(), conn, time.Second)
|
|
|
|
groupAdminObj := "groupadmin"
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
subject string
|
|
object string
|
|
relation string
|
|
ar *mainflux.AddPolicyRes
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "add groupadmin policy to user",
|
|
token: loginSecret,
|
|
subject: id,
|
|
object: groupAdminObj,
|
|
relation: memberRelation,
|
|
ar: &mainflux.AddPolicyRes{Authorized: true},
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "add policy to user with invalid ACL",
|
|
token: loginSecret,
|
|
subject: "",
|
|
object: "",
|
|
relation: "",
|
|
ar: &mainflux.AddPolicyRes{Authorized: false},
|
|
err: nil,
|
|
code: codes.InvalidArgument,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
apr, err := client.AddPolicy(context.Background(), &mainflux.AddPolicyReq{Sub: tc.subject, Obj: tc.object, Act: tc.relation})
|
|
if apr != nil {
|
|
assert.Equal(t, tc.ar, apr, fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.ar, apr))
|
|
}
|
|
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
}
|
|
}
|
|
|
|
func TestDeletePolicy(t *testing.T) {
|
|
_, loginSecret, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.LoginKey, IssuedAt: time.Now(), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, err := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
require.Nil(t, err, fmt.Sprintf("got unexpected error while creating client connection: %s", err))
|
|
|
|
client := grpcapi.NewClient(mocktracer.New(), conn, time.Second)
|
|
|
|
readRelation := "read"
|
|
thingID := "thing"
|
|
|
|
apr, err := client.AddPolicy(context.Background(), &mainflux.AddPolicyReq{Sub: id, Obj: thingID, Act: readRelation})
|
|
require.Nil(t, err, fmt.Sprintf("Adding read policy to user expected to succeed: %s", err))
|
|
require.True(t, apr.GetAuthorized(), fmt.Sprintf("Adding read policy expected to make user authorized, expected %v got %v", true, apr.GetAuthorized()))
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
subject string
|
|
object string
|
|
relation string
|
|
dpr *mainflux.DeletePolicyRes
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "delete valid policy",
|
|
token: loginSecret,
|
|
subject: id,
|
|
object: thingID,
|
|
relation: readRelation,
|
|
dpr: &mainflux.DeletePolicyRes{Deleted: true},
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "delete invalid policy",
|
|
token: loginSecret,
|
|
subject: "",
|
|
object: "",
|
|
relation: "",
|
|
dpr: &mainflux.DeletePolicyRes{Deleted: false},
|
|
code: codes.InvalidArgument,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
dpr, err := client.DeletePolicy(context.Background(), &mainflux.DeletePolicyReq{Sub: tc.subject, Obj: tc.object, Act: tc.relation})
|
|
e, ok := status.FromError(err)
|
|
assert.True(t, ok, "gRPC status can't be extracted from the error")
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
assert.Equal(t, tc.dpr.GetDeleted(), dpr.GetDeleted(), fmt.Sprintf("%s: expected %v got %v", tc.desc, tc.dpr.GetDeleted(), dpr.GetDeleted()))
|
|
}
|
|
}
|
|
|
|
func TestMembers(t *testing.T) {
|
|
_, token, err := svc.Issue(context.Background(), "", auth.Key{Type: auth.LoginKey, IssuedAt: time.Now(), IssuerID: id, Subject: email})
|
|
require.Nil(t, err, fmt.Sprintf("Issuing user key expected to succeed: %s", err))
|
|
|
|
group := auth.Group{
|
|
Name: "Mainflux",
|
|
Description: description,
|
|
}
|
|
|
|
var things []string
|
|
for i := 0; i < numOfThings; i++ {
|
|
thID, err := uuid.New().ID()
|
|
require.Nil(t, err, fmt.Sprintf("Generate thing id expected to succeed: %s", err))
|
|
|
|
err = svc.AddPolicy(context.Background(), auth.PolicyReq{Subject: id, Object: thID, Relation: "owner"})
|
|
require.Nil(t, err, fmt.Sprintf("Adding a policy expected to succeed: %s", err))
|
|
|
|
things = append(things, thID)
|
|
}
|
|
|
|
var users []string
|
|
for i := 0; i < numOfUsers; i++ {
|
|
id, err := uuid.New().ID()
|
|
require.Nil(t, err, fmt.Sprintf("Generate thing id expected to succeed: %s", err))
|
|
|
|
users = append(users, id)
|
|
}
|
|
|
|
group, err = svc.CreateGroup(context.Background(), token, group)
|
|
require.Nil(t, err, fmt.Sprintf("Creating group expected to succeed: %s", err))
|
|
err = svc.AddPolicy(context.Background(), auth.PolicyReq{Subject: id, Object: group.ID, Relation: "groupadmin"})
|
|
require.Nil(t, err, fmt.Sprintf("Adding a policy expected to succeed: %s", err))
|
|
|
|
err = svc.Assign(context.Background(), token, group.ID, thingsType, things...)
|
|
require.Nil(t, err, fmt.Sprintf("Assign members to expected to succeed: %s", err))
|
|
|
|
err = svc.Assign(context.Background(), token, group.ID, usersType, users...)
|
|
require.Nil(t, err, fmt.Sprintf("Assign members to group expected to succeed: %s", err))
|
|
|
|
cases := []struct {
|
|
desc string
|
|
token string
|
|
groupID string
|
|
groupType string
|
|
size int
|
|
err error
|
|
code codes.Code
|
|
}{
|
|
{
|
|
desc: "get all things with user token",
|
|
groupID: group.ID,
|
|
token: token,
|
|
groupType: thingsType,
|
|
size: numOfThings,
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
{
|
|
desc: "get all users with user token",
|
|
groupID: group.ID,
|
|
token: token,
|
|
groupType: usersType,
|
|
size: numOfUsers,
|
|
err: nil,
|
|
code: codes.OK,
|
|
},
|
|
}
|
|
|
|
authAddr := fmt.Sprintf("localhost:%d", port)
|
|
conn, err := grpc.Dial(authAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
require.Nil(t, err, fmt.Sprintf("got unexpected error while creating client connection: %s", err))
|
|
|
|
client := grpcapi.NewClient(mocktracer.New(), conn, time.Second)
|
|
|
|
for _, tc := range cases {
|
|
m, err := client.Members(context.Background(), &mainflux.MembersReq{Token: tc.token, GroupID: tc.groupID, Type: tc.groupType, Offset: 0, Limit: 10})
|
|
e, ok := status.FromError(err)
|
|
assert.Equal(t, tc.size, len(m.Members), fmt.Sprintf("%s: expected %d got %d", tc.desc, tc.size, len(m.Members)))
|
|
assert.Equal(t, tc.code, e.Code(), fmt.Sprintf("%s: expected %s got %s", tc.desc, tc.code, e.Code()))
|
|
assert.True(t, ok, "OK expected to be true")
|
|
}
|
|
}
|