1
0
mirror of https://github.com/mainflux/mainflux.git synced 2025-04-29 13:49:28 +08:00
Manuel Imperiale 1c298d8f27
NOISSUE - Add ListUsers, ViewUser and ViewProfile methods (#1262)
* NOISSUE - Add admin method in users service to return users list

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix loggings and metrics

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add email and metadata filters

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add comment

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Retrieve User infos by ID if Admin

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Remove admin checks and fix comments

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix missing query

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Use generic funccs to create email and metadata queries

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add /users/profile endpoint

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Simplify db helpers

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix View, List, Retrieve prefix methods naming

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix tracer endpoints naming

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix comment

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add tests and remove TODO comments

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
2020-10-26 10:17:08 +01:00

394 lines
9.0 KiB
Go

// Copyright (c) Mainflux
// SPDX-License-Identifier: Apache-2.0
package postgres
import (
"context"
"database/sql"
"database/sql/driver"
"encoding/json"
"fmt"
"github.com/lib/pq"
"github.com/mainflux/mainflux/pkg/errors"
"github.com/mainflux/mainflux/users"
)
var (
errSaveUserDB = errors.New("Save user to DB failed")
errUpdateDB = errors.New("Update user email to DB failed")
errUpdateUserDB = errors.New("Update user metadata to DB failed")
errRetrieveDB = errors.New("Retreiving from DB failed")
errUpdatePasswordDB = errors.New("Update password to DB failed")
errMarshal = errors.New("Failed to marshal metadata")
errUnmarshal = errors.New("Failed to unmarshal metadata")
)
var _ users.UserRepository = (*userRepository)(nil)
const errDuplicate = "unique_violation"
type userRepository struct {
db Database
}
// NewUserRepo instantiates a PostgreSQL implementation of user
// repository.
func NewUserRepo(db Database) users.UserRepository {
return &userRepository{
db: db,
}
}
func (ur userRepository) Save(ctx context.Context, user users.User) (string, error) {
q := `INSERT INTO users (email, password, id, metadata) VALUES (:email, :password, :id, :metadata) RETURNING id`
if user.ID == "" || user.Email == "" {
return "", users.ErrMalformedEntity
}
dbu, err := toDBUser(user)
if err != nil {
return "", errors.Wrap(errSaveUserDB, err)
}
row, err := ur.db.NamedQueryContext(ctx, q, dbu)
if err != nil {
pqErr, ok := err.(*pq.Error)
if ok {
switch pqErr.Code.Name() {
case errInvalid, errTruncation:
return "", errors.Wrap(users.ErrMalformedEntity, err)
case errDuplicate:
return "", errors.Wrap(users.ErrConflict, err)
}
}
return "", errors.Wrap(errSaveUserDB, err)
}
defer row.Close()
row.Next()
var id string
if err := row.Scan(&id); err != nil {
return "", err
}
return id, nil
}
func (ur userRepository) Update(ctx context.Context, user users.User) error {
q := `UPDATE users SET(email, password, metadata) VALUES (:email, :password, :metadata) WHERE email = :email`
dbu, err := toDBUser(user)
if err != nil {
return errors.Wrap(errUpdateDB, err)
}
if _, err := ur.db.NamedExecContext(ctx, q, dbu); err != nil {
return errors.Wrap(errUpdateDB, err)
}
return nil
}
func (ur userRepository) UpdateUser(ctx context.Context, user users.User) error {
q := `UPDATE users SET metadata = :metadata WHERE email = :email`
dbu, err := toDBUser(user)
if err != nil {
return errors.Wrap(errUpdateUserDB, err)
}
if _, err := ur.db.NamedExecContext(ctx, q, dbu); err != nil {
return errors.Wrap(errUpdateUserDB, err)
}
return nil
}
func (ur userRepository) RetrieveByEmail(ctx context.Context, email string) (users.User, error) {
q := `SELECT id, password, metadata FROM users WHERE email = $1`
dbu := dbUser{
Email: email,
}
if err := ur.db.QueryRowxContext(ctx, q, email).StructScan(&dbu); err != nil {
if err == sql.ErrNoRows {
return users.User{}, errors.Wrap(users.ErrNotFound, err)
}
return users.User{}, errors.Wrap(errRetrieveDB, err)
}
return toUser(dbu)
}
func (ur userRepository) RetrieveByID(ctx context.Context, id string) (users.User, error) {
q := `SELECT email, password, metadata FROM users WHERE id = $1`
dbu := dbUser{
ID: id,
}
if err := ur.db.QueryRowxContext(ctx, q, id).StructScan(&dbu); err != nil {
if err == sql.ErrNoRows {
return users.User{}, errors.Wrap(users.ErrNotFound, err)
}
return users.User{}, errors.Wrap(errRetrieveDB, err)
}
return toUser(dbu)
}
func (ur userRepository) RetrieveAll(ctx context.Context, offset, limit uint64, email string, um users.Metadata) (users.UserPage, error) {
eq, ep, err := createEmailQuery("", email)
if err != nil {
return users.UserPage{}, errors.Wrap(errRetrieveDB, err)
}
mq, mp, err := createMetadataQuery("", um)
if err != nil {
return users.UserPage{}, errors.Wrap(errRetrieveDB, err)
}
emq := ""
if eq != "" && mq == "" {
emq = fmt.Sprintf("WHERE %s", eq)
}
if eq == "" && mq != "" {
emq = fmt.Sprintf("WHERE %s", mq)
}
if eq != "" && mq != "" {
emq = fmt.Sprintf("WHERE %s AND %s", eq, mq)
}
q := fmt.Sprintf(`SELECT id, email, metadata FROM users %s ORDER BY email LIMIT :limit OFFSET :offset;`, emq)
params := map[string]interface{}{
"limit": limit,
"offset": offset,
"email": ep,
"metadata": mp,
}
rows, err := ur.db.NamedQueryContext(ctx, q, params)
if err != nil {
return users.UserPage{}, errors.Wrap(errSelectDb, err)
}
defer rows.Close()
var items []users.User
for rows.Next() {
dbusr := dbUser{}
if err := rows.StructScan(&dbusr); err != nil {
return users.UserPage{}, errors.Wrap(errSelectDb, err)
}
user, err := toUser(dbusr)
if err != nil {
return users.UserPage{}, err
}
items = append(items, user)
}
cq := fmt.Sprintf(`SELECT COUNT(*) FROM users %s;`, emq)
total, err := total(ctx, ur.db, cq, params)
if err != nil {
return users.UserPage{}, errors.Wrap(errSelectDb, err)
}
page := users.UserPage{
Users: items,
PageMetadata: users.PageMetadata{
Total: total,
Offset: offset,
Limit: limit,
},
}
return page, nil
}
func (ur userRepository) UpdatePassword(ctx context.Context, email, password string) error {
q := `UPDATE users SET password = :password WHERE email = :email`
db := dbUser{
Email: email,
Password: password,
}
if _, err := ur.db.NamedExecContext(ctx, q, db); err != nil {
return errors.Wrap(errUpdatePasswordDB, err)
}
return nil
}
func (ur userRepository) RetrieveMembers(ctx context.Context, groupID string, offset, limit uint64, um users.Metadata) (users.UserPage, error) {
mq, mp, err := createMetadataQuery("users.", um)
if err != nil {
return users.UserPage{}, errors.Wrap(errRetrieveDB, err)
}
if mq != "" {
mq = fmt.Sprintf(" AND %s", mq)
}
q := fmt.Sprintf(`SELECT u.id, u.email, u.metadata FROM users u, group_relations g
WHERE u.id = g.user_id AND g.group_id = :group
%s ORDER BY id LIMIT :limit OFFSET :offset;`, mq)
params := map[string]interface{}{
"group": groupID,
"limit": limit,
"offset": offset,
"metadata": mp,
}
rows, err := ur.db.NamedQueryContext(ctx, q, params)
if err != nil {
return users.UserPage{}, errors.Wrap(errSelectDb, err)
}
defer rows.Close()
var items []users.User
for rows.Next() {
dbusr := dbUser{}
if err := rows.StructScan(&dbusr); err != nil {
return users.UserPage{}, errors.Wrap(errSelectDb, err)
}
user, err := toUser(dbusr)
if err != nil {
return users.UserPage{}, err
}
items = append(items, user)
}
cq := fmt.Sprintf(`SELECT COUNT(*) FROM users u, group_relations g
WHERE u.id = g.user_id AND g.group_id = :group %s;`, mq)
total, err := total(ctx, ur.db, cq, params)
if err != nil {
return users.UserPage{}, errors.Wrap(errSelectDb, err)
}
page := users.UserPage{
Users: items,
PageMetadata: users.PageMetadata{
Total: total,
Offset: offset,
Limit: limit,
},
}
return page, nil
}
// dbMetadata type for handling metadata properly in database/sql
type dbMetadata map[string]interface{}
// Scan - Implement the database/sql scanner interface
func (m *dbMetadata) Scan(value interface{}) error {
if value == nil {
return nil
}
b, ok := value.([]byte)
if !ok {
return users.ErrScanMetadata
}
if err := json.Unmarshal(b, m); err != nil {
return err
}
return nil
}
// Value Implements valuer
func (m dbMetadata) Value() (driver.Value, error) {
if len(m) == 0 {
return nil, nil
}
b, err := json.Marshal(m)
if err != nil {
return nil, err
}
return b, err
}
type dbUser struct {
ID string `db:"id"`
Owner string `db:"owner"`
Email string `db:"email"`
Password string `db:"password"`
Metadata []byte `db:"metadata"`
Groups []users.Group `db:"groups"`
}
func toDBUser(u users.User) (dbUser, error) {
data := []byte("{}")
if len(u.Metadata) > 0 {
b, err := json.Marshal(u.Metadata)
if err != nil {
return dbUser{}, errors.Wrap(errMarshal, err)
}
data = b
}
return dbUser{
ID: u.ID,
Email: u.Email,
Password: u.Password,
Metadata: data,
}, nil
}
func toUser(dbu dbUser) (users.User, error) {
var metadata map[string]interface{}
if dbu.Metadata != nil {
if err := json.Unmarshal([]byte(dbu.Metadata), &metadata); err != nil {
return users.User{}, errors.Wrap(errUnmarshal, err)
}
}
return users.User{
ID: dbu.ID,
Email: dbu.Email,
Password: dbu.Password,
Metadata: metadata,
}, nil
}
func createEmailQuery(entity string, email string) (string, string, error) {
if email == "" {
return "", "", nil
}
// Create LIKE operator to search Users with email containing a given string
param := fmt.Sprintf(`%%%s%%`, email)
query := fmt.Sprintf("%semail LIKE :email", entity)
return query, param, nil
}
func createMetadataQuery(entity string, um users.Metadata) (string, []byte, error) {
if len(um) == 0 {
return "", nil, nil
}
param, err := json.Marshal(um)
if err != nil {
return "", nil, err
}
query := fmt.Sprintf("%smetadata @> :metadata", entity)
return query, param, nil
}