From 031e0a62f2d2eb16f2a1f2aae969f3cf817bc508 Mon Sep 17 00:00:00 2001 From: Ian Ngethe Muchiri <100555904+ianmuchyri@users.noreply.github.com> Date: Thu, 13 Jul 2023 00:02:59 +0300 Subject: [PATCH] NOISSUE-Update invalid secret error handling (#1856) * update invalid secret error handling Signed-off-by: ianmuchyri * update secret error naming Signed-off-by: ianmuchyri * update secretError naming Signed-off-by: ianmuchyri * fix comment Signed-off-by: ianmuchyri * add empty space in comment Signed-off-by: ianmuchyri --------- Signed-off-by: ianmuchyri --- pkg/errors/types.go | 3 +++ users/clients/service.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/errors/types.go b/pkg/errors/types.go index a3a5926d..7437313a 100644 --- a/pkg/errors/types.go +++ b/pkg/errors/types.go @@ -42,4 +42,7 @@ var ( // ErrScanMetadata indicates problem with metadata in db. ErrScanMetadata = New("failed to scan metadata in db") + + // ErrWrongSecret indicates a wrong secret was provided. + ErrWrongSecret = New("wrong secret") ) diff --git a/users/clients/service.go b/users/clients/service.go index 057625b9..afc398ca 100644 --- a/users/clients/service.go +++ b/users/clients/service.go @@ -111,7 +111,7 @@ func (svc service) IssueToken(ctx context.Context, identity, secret string) (jwt return jwt.Token{}, errors.Wrap(errors.ErrAuthentication, err) } if err := svc.hasher.Compare(secret, dbUser.Credentials.Secret); err != nil { - return jwt.Token{}, errors.Wrap(errors.ErrAuthentication, err) + return jwt.Token{}, errors.Wrap(errors.ErrWrongSecret, err) } claims := jwt.Claims{ @@ -315,7 +315,7 @@ func (svc service) UpdateClientSecret(ctx context.Context, token, oldSecret, new return mfclients.Client{}, err } if _, err := svc.IssueToken(ctx, dbClient.Credentials.Identity, oldSecret); err != nil { - return mfclients.Client{}, errors.ErrAuthentication + return mfclients.Client{}, err } newSecret, err = svc.hasher.Hash(newSecret) if err != nil {