1
0
mirror of https://github.com/mainflux/mainflux.git synced 2025-04-24 13:48:49 +08:00
Mainflux.mainflux/pkg/sdk/go/groups_test.go

838 lines
23 KiB
Go
Raw Normal View History

NOISSUE - Add More Linters (#1924) * Fix linting errors Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * feat(linters): add ineffassign linter This commit adds the `ineffassign` linter to the project's `.golangci.yml` configuration file. The `ineffassign` linter helps identify and flag assignments to variables that are never used, helping to improve code quality and maintainability. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * Add extra linters Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * feat(golangci): Add header check - Added goheader check to ensure all files have license headers - Added build tags for "nats" in the .golangci.yml file to include the necessary dependencies for the "nats" package during the build process. - Also, increased the maximum number of issues per linter and the maximum number of same issues reported by the linter to improve the code quality analysis. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * feat(.golangci.yml): Add new linters Add the following new linters to the .golangci.yml configuration file: - asasalint - asciicheck - bidichk - contextcheck - decorder - dogsled - errchkjson - errname - execinquery - exportloopref - ginkgolinter - gocheckcompilerdirectives These linters will help improve code quality and catch potential issues during the code review process. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> --------- Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
2023-10-16 12:43:33 +03:00
// Copyright (c) Mainflux
// SPDX-License-Identifier: Apache-2.0
MF-1506 - Group-based Access Control (#1716) * Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Update Add and Delete Policies (#1792) * Remove Policy Action Ranks Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Rebase Issues Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix CI Test Errors Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Adding Check on Subject For Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Check Client Exists Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check When Sharing Clients Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Only Add User to Group When Sharing Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove clientType Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Minor Fix on ShareClient and Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Clean Up Things Authorization Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests on RetrieveAll Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Test ShareThing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Merge Conflicts Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Remove Adding Policies. Only Use Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Check If Subject is same as Object Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Move Back To Union As Sometimes Policy is Empty and Fails to Evaluate on Ownership Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Entity Type For Failing Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix BUG in policy evaluation Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Comments Regarding checkAdmin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine Authorize For Things and Users Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests On Rebase Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Error on Things SVC `unsupported protocol scheme` Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix Bug on Things Authorization Cache (#1810) Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Use Password instead of username in MQTT handler Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Simplify MQTT authorization Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * Fix MQTT tests Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add More Functions to SDK (#1811) * Add More Functions to SDK Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Examples to GoDoc Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update Unassign Interface Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Pass Subject as ID and Not Token on List Channels By Thing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Bootstrap Errors For Element Check Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add empty line Before Return Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Reorder URLS in things mux Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Listing Things Policies Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Share Thing Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Examples to CLI Docs Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Update Identity To Update Another User Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Identify an Update Policies on Things Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Update Things Policies Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix GoDocs on Disconnect Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Change Authorize To Use AccessRequest Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * For Evaluate Policy Use AccessRequest (#1814) Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add SDK Tests (#1812) * Add Things Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Channel Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Certs Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Consumer Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Enrich Group Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Tests For Health Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Tests For Tokens Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Rename SDK for Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Policies Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Linter Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Fix Tests Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Make Variable Defination Inline Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Make Cache Key Duration Configurable (#1815) * Make Cache Key Duration Configurable Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Rename ENV Var Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Update GoDocs (#1816) * Add GoDocs Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add Missing GoDoc Files Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Enable godot Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Add License Information Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> * NOISSUE - Add Call Home Client to Mainflux services (#1751) * Move Things and Users to Clients Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> * collect and send data package Signed-off-by: SammyOina <sammyoina@gmail.com> * create telemetry migrations Signed-off-by: SammyOina <sammyoina@gmail.com> * add telemetry endpoints Signed-off-by: SammyOina <sammyoina@gmail.com> * add transport Signed-off-by: SammyOina <sammyoina@gmail.com> * create service Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing server Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to adapters Signed-off-by: SammyOina <sammyoina@gmail.com> * add last seen Signed-off-by: SammyOina <sammyoina@gmail.com> * rename logger Signed-off-by: SammyOina <sammyoina@gmail.com> * remove homing client Signed-off-by: SammyOina <sammyoina@gmail.com> * use unmerged repo Signed-off-by: SammyOina <sammyoina@gmail.com> * use renamed module Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home version Signed-off-by: SammyOina <sammyoina@gmail.com> * edit documentation Signed-off-by: SammyOina <sammyoina@gmail.com> * align table Signed-off-by: SammyOina <sammyoina@gmail.com> * use alias for call home client Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home pkg Signed-off-by: SammyOina <sammyoina@gmail.com> * update call home Signed-off-by: SammyOina <sammyoina@gmail.com> * fix modules Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * use mf build version Signed-off-by: SammyOina <sammyoina@gmail.com> * restore default Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home for users and things Signed-off-by: SammyOina <sammyoina@gmail.com> * enable opting on call home Signed-off-by: SammyOina <sammyoina@gmail.com> * remove full stops Signed-off-by: SammyOina <sammyoina@gmail.com> * update callhome client Signed-off-by: SammyOina <sammyoina@gmail.com> * add call home to all services Signed-off-by: SammyOina <sammyoina@gmail.com> * fix build Signed-off-by: SammyOina <sammyoina@gmail.com> * restore sdk tests Signed-off-by: SammyOina <sammyoina@gmail.com> * remove unnecessary changes Signed-off-by: SammyOina <sammyoina@gmail.com> * restore health_test.go Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> --------- Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com>
2023-06-14 12:40:37 +02:00
package sdk_test
import (
"fmt"
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/go-chi/chi/v5"
authmocks "github.com/mainflux/mainflux/auth/mocks"
"github.com/mainflux/mainflux/internal/apiutil"
"github.com/mainflux/mainflux/internal/groups"
gmocks "github.com/mainflux/mainflux/internal/groups/mocks"
"github.com/mainflux/mainflux/internal/testsutil"
mflog "github.com/mainflux/mainflux/logger"
"github.com/mainflux/mainflux/pkg/clients"
"github.com/mainflux/mainflux/pkg/errors"
mfgroups "github.com/mainflux/mainflux/pkg/groups"
sdk "github.com/mainflux/mainflux/pkg/sdk/go"
"github.com/mainflux/mainflux/users"
"github.com/mainflux/mainflux/users/api"
"github.com/mainflux/mainflux/users/mocks"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)
func newGroupsServer() (*httptest.Server, *mocks.Repository, *gmocks.Repository, *authmocks.Service) {
cRepo := new(mocks.Repository)
gRepo := new(gmocks.Repository)
auth := new(authmocks.Service)
csvc := users.NewService(cRepo, auth, emailer, phasher, idProvider, passRegex)
gsvc := groups.NewService(gRepo, idProvider, auth)
logger := mflog.NewMock()
mux := chi.NewRouter()
api.MakeHandler(csvc, gsvc, mux, logger, "")
return httptest.NewServer(mux), cRepo, gRepo, auth
}
func TestCreateGroup(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
group := sdk.Group{
Name: "groupName",
Metadata: validMetadata,
Status: clients.EnabledStatus.String(),
}
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
cases := []struct {
desc string
group sdk.Group
token string
err errors.SDKError
}{
{
desc: "create group successfully",
group: group,
token: token,
err: nil,
},
{
desc: "create group with existing name",
group: group,
err: nil,
},
{
desc: "create group with parent",
group: sdk.Group{
Name: gName,
ParentID: testsutil.GenerateUUID(t),
Status: clients.EnabledStatus.String(),
},
err: nil,
},
{
desc: "create group with invalid parent",
group: sdk.Group{
Name: gName,
ParentID: gmocks.WrongID,
Status: clients.EnabledStatus.String(),
},
err: errors.NewSDKErrorWithStatus(errors.ErrCreateEntity, http.StatusInternalServerError),
},
{
desc: "create group with invalid owner",
group: sdk.Group{
Name: gName,
OwnerID: gmocks.WrongID,
Status: clients.EnabledStatus.String(),
},
err: errors.NewSDKErrorWithStatus(sdk.ErrFailedCreation, http.StatusInternalServerError),
},
{
desc: "create group with missing name",
group: sdk.Group{
Status: clients.EnabledStatus.String(),
},
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, apiutil.ErrNameSize), http.StatusBadRequest),
},
{
desc: "create a group with every field defined",
group: sdk.Group{
ID: generateUUID(t),
OwnerID: "owner",
ParentID: "parent",
Name: "name",
Description: description,
Metadata: validMetadata,
Level: 1,
Children: []*sdk.Group{&group},
CreatedAt: time.Now(),
UpdatedAt: time.Now(),
Status: clients.EnabledStatus.String(),
},
token: token,
err: nil,
},
{
desc: "create a group that can't be marshalled",
group: sdk.Group{
Name: "test",
Metadata: map[string]interface{}{
"test": make(chan int),
},
},
token: token,
err: errors.NewSDKError(fmt.Errorf("json: unsupported type: chan int")),
},
}
for _, tc := range cases {
repoCall := gRepo.On("Save", mock.Anything, mock.Anything).Return(convertGroup(sdk.Group{}), tc.err)
rGroup, err := mfsdk.CreateGroup(tc.group, validToken)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: unexpected error %s", tc.desc, err))
if err == nil {
assert.NotEmpty(t, rGroup, fmt.Sprintf("%s: expected not nil on client ID", tc.desc))
ok := repoCall.Parent.AssertCalled(t, "Save", mock.Anything, mock.Anything)
assert.True(t, ok, fmt.Sprintf("Save was not called on %s", tc.desc))
}
repoCall.Unset()
}
}
func TestListGroups(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
var grps []sdk.Group
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
for i := 10; i < 100; i++ {
gr := sdk.Group{
ID: generateUUID(t),
Name: fmt.Sprintf("group_%d", i),
Metadata: sdk.Metadata{"name": fmt.Sprintf("user_%d", i)},
Status: clients.EnabledStatus.String(),
}
grps = append(grps, gr)
}
cases := []struct {
desc string
token string
status clients.Status
total uint64
offset uint64
limit uint64
level int
name string
ownerID string
metadata sdk.Metadata
err errors.SDKError
response []sdk.Group
}{
{
desc: "get a list of groups",
token: token,
limit: limit,
offset: offset,
total: total,
err: nil,
response: grps[offset:limit],
},
{
desc: "get a list of groups with invalid token",
token: invalidToken,
offset: offset,
limit: limit,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with empty token",
token: "",
offset: offset,
limit: limit,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with zero limit",
token: token,
offset: offset,
limit: 0,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with limit greater than max",
token: token,
offset: offset,
limit: 110,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: []sdk.Group(nil),
},
{
desc: "get a list of groups with given name",
token: token,
offset: 0,
limit: 1,
err: nil,
metadata: sdk.Metadata{},
response: []sdk.Group{grps[89]},
},
{
desc: "get a list of groups with level",
token: token,
offset: 0,
limit: 1,
level: 1,
err: nil,
response: []sdk.Group{grps[0]},
},
{
desc: "get a list of groups with metadata",
token: token,
offset: 0,
limit: 1,
err: nil,
metadata: sdk.Metadata{},
response: []sdk.Group{grps[89]},
},
}
for _, tc := range cases {
repoCall1 := gRepo.On("RetrieveAll", mock.Anything, mock.Anything).Return(mfgroups.Page{Groups: convertGroups(tc.response)}, tc.err)
pm := sdk.PageMetadata{}
page, err := mfsdk.Groups(pm, validToken)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected error %s, got %s", tc.desc, tc.err, err))
assert.Equal(t, len(tc.response), len(page.Groups), fmt.Sprintf("%s: expected %v got %v\n", tc.desc, tc.response, page))
if tc.err == nil {
ok := repoCall1.Parent.AssertCalled(t, "RetrieveAll", mock.Anything, mock.Anything)
assert.True(t, ok, fmt.Sprintf("RetrieveAll was not called on %s", tc.desc))
}
repoCall1.Unset()
}
}
func TestListParentGroups(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
var grps []sdk.Group
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
parentID := ""
for i := 10; i < 100; i++ {
gr := sdk.Group{
ID: generateUUID(t),
Name: fmt.Sprintf("group_%d", i),
Metadata: sdk.Metadata{"name": fmt.Sprintf("user_%d", i)},
Status: clients.EnabledStatus.String(),
ParentID: parentID,
}
parentID = gr.ID
grps = append(grps, gr)
}
cases := []struct {
desc string
token string
status clients.Status
total uint64
offset uint64
limit uint64
level int
name string
ownerID string
metadata sdk.Metadata
err errors.SDKError
response []sdk.Group
}{
{
desc: "get a list of groups",
token: token,
limit: limit,
offset: offset,
total: total,
err: nil,
response: grps[offset:limit],
},
{
desc: "get a list of groups with invalid token",
token: invalidToken,
offset: offset,
limit: limit,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with empty token",
token: "",
offset: offset,
limit: limit,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with zero limit",
token: token,
offset: offset,
limit: 0,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with limit greater than max",
token: token,
offset: offset,
limit: 110,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: []sdk.Group(nil),
},
{
desc: "get a list of groups with given name",
token: token,
offset: 0,
limit: 1,
err: nil,
metadata: sdk.Metadata{},
response: []sdk.Group{grps[89]},
},
{
desc: "get a list of groups with level",
token: token,
offset: 0,
limit: 1,
level: 1,
err: nil,
response: []sdk.Group{grps[0]},
},
{
desc: "get a list of groups with metadata",
token: token,
offset: 0,
limit: 1,
err: nil,
metadata: sdk.Metadata{},
response: []sdk.Group{grps[89]},
},
}
for _, tc := range cases {
repoCall1 := gRepo.On("RetrieveAll", mock.Anything, mock.Anything).Return(mfgroups.Page{Groups: convertGroups(tc.response)}, tc.err)
pm := sdk.PageMetadata{}
page, err := mfsdk.Parents(parentID, pm, validToken)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected error %s, got %s", tc.desc, tc.err, err))
assert.Equal(t, len(tc.response), len(page.Groups), fmt.Sprintf("%s: expected %v got %v\n", tc.desc, tc.response, page))
if tc.err == nil {
ok := repoCall1.Parent.AssertCalled(t, "RetrieveAll", mock.Anything, mock.Anything)
assert.True(t, ok, fmt.Sprintf("RetrieveAll was not called on %s", tc.desc))
}
repoCall1.Unset()
}
}
func TestListChildrenGroups(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
var grps []sdk.Group
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
parentID := ""
for i := 10; i < 100; i++ {
gr := sdk.Group{
ID: generateUUID(t),
Name: fmt.Sprintf("group_%d", i),
Metadata: sdk.Metadata{"name": fmt.Sprintf("user_%d", i)},
Status: clients.EnabledStatus.String(),
ParentID: parentID,
}
parentID = gr.ID
grps = append(grps, gr)
}
childID := grps[0].ID
cases := []struct {
desc string
token string
status clients.Status
total uint64
offset uint64
limit uint64
level int
name string
ownerID string
metadata sdk.Metadata
err errors.SDKError
response []sdk.Group
}{
{
desc: "get a list of groups",
token: token,
limit: limit,
offset: offset,
total: total,
err: nil,
response: grps[offset:limit],
},
{
desc: "get a list of groups with invalid token",
token: invalidToken,
offset: offset,
limit: limit,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with empty token",
token: "",
offset: offset,
limit: limit,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with zero limit",
token: token,
offset: offset,
limit: 0,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: nil,
},
{
desc: "get a list of groups with limit greater than max",
token: token,
offset: offset,
limit: 110,
err: errors.NewSDKErrorWithStatus(errors.Wrap(apiutil.ErrValidation, sdk.ErrFailedList), http.StatusInternalServerError),
response: []sdk.Group(nil),
},
{
desc: "get a list of groups with given name",
token: token,
offset: 0,
limit: 1,
err: nil,
metadata: sdk.Metadata{},
response: []sdk.Group{grps[89]},
},
{
desc: "get a list of groups with level",
token: token,
offset: 0,
limit: 1,
level: 1,
err: nil,
response: []sdk.Group{grps[0]},
},
{
desc: "get a list of groups with metadata",
token: token,
offset: 0,
limit: 1,
err: nil,
metadata: sdk.Metadata{},
response: []sdk.Group{grps[89]},
},
}
for _, tc := range cases {
repoCall1 := gRepo.On("RetrieveAll", mock.Anything, mock.Anything).Return(mfgroups.Page{Groups: convertGroups(tc.response)}, tc.err)
pm := sdk.PageMetadata{}
page, err := mfsdk.Children(childID, pm, validToken)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected error %s, got %s", tc.desc, tc.err, err))
assert.Equal(t, len(tc.response), len(page.Groups), fmt.Sprintf("%s: expected %v got %v\n", tc.desc, tc.response, page))
if tc.err == nil {
ok := repoCall1.Parent.AssertCalled(t, "RetrieveAll", mock.Anything, mock.Anything)
assert.True(t, ok, fmt.Sprintf("RetrieveAll was not called on %s", tc.desc))
}
repoCall1.Unset()
}
}
func TestViewGroup(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
group := sdk.Group{
Name: "groupName",
Description: description,
Metadata: validMetadata,
Children: []*sdk.Group{},
Status: clients.EnabledStatus.String(),
}
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
group.ID = generateUUID(t)
cases := []struct {
desc string
token string
groupID string
response sdk.Group
err errors.SDKError
}{
{
desc: "view group",
token: validToken,
groupID: group.ID,
response: group,
err: nil,
},
{
desc: "view group with invalid token",
token: "wrongtoken",
groupID: group.ID,
response: sdk.Group{Children: []*sdk.Group{}},
err: errors.NewSDKErrorWithStatus(errors.Wrap(errors.ErrAuthentication, sdk.ErrInvalidJWT), http.StatusUnauthorized),
},
{
desc: "view group for wrong id",
token: validToken,
groupID: gmocks.WrongID,
response: sdk.Group{Children: []*sdk.Group{}},
err: errors.NewSDKErrorWithStatus(errors.ErrNotFound, http.StatusNotFound),
},
}
for _, tc := range cases {
repoCall1 := gRepo.On("RetrieveByID", mock.Anything, tc.groupID).Return(convertGroup(tc.response), tc.err)
grp, err := mfsdk.Group(tc.groupID, tc.token)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected error %s, got %s", tc.desc, tc.err, err))
if len(tc.response.Children) == 0 {
tc.response.Children = nil
}
if len(grp.Children) == 0 {
grp.Children = nil
}
assert.Equal(t, tc.response, grp, fmt.Sprintf("%s: expected metadata %v got %v\n", tc.desc, tc.response, grp))
if tc.err == nil {
ok := repoCall1.Parent.AssertCalled(t, "RetrieveByID", mock.Anything, tc.groupID)
assert.True(t, ok, fmt.Sprintf("RetrieveByID was not called on %s", tc.desc))
}
repoCall1.Unset()
}
}
func TestUpdateGroup(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
group := sdk.Group{
ID: generateUUID(t),
Name: "groupName",
Description: description,
Metadata: validMetadata,
}
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
group.ID = generateUUID(t)
cases := []struct {
desc string
token string
group sdk.Group
response sdk.Group
err errors.SDKError
}{
{
desc: "update group name",
group: sdk.Group{
ID: group.ID,
Name: "NewName",
},
response: sdk.Group{
ID: group.ID,
Name: "NewName",
},
token: validToken,
err: nil,
},
{
desc: "update group description",
group: sdk.Group{
ID: group.ID,
Description: "NewDescription",
},
response: sdk.Group{
ID: group.ID,
Description: "NewDescription",
},
token: validToken,
err: nil,
},
{
desc: "update group metadata",
group: sdk.Group{
ID: group.ID,
Metadata: sdk.Metadata{
"field": "value2",
},
},
response: sdk.Group{
ID: group.ID,
Metadata: sdk.Metadata{
"field": "value2",
},
},
token: validToken,
err: nil,
},
{
desc: "update group name with invalid group id",
group: sdk.Group{
ID: gmocks.WrongID,
Name: "NewName",
},
response: sdk.Group{},
token: validToken,
err: errors.NewSDKErrorWithStatus(errors.ErrNotFound, http.StatusNotFound),
},
{
desc: "update group description with invalid group id",
group: sdk.Group{
ID: gmocks.WrongID,
Description: "NewDescription",
},
response: sdk.Group{},
token: validToken,
err: errors.NewSDKErrorWithStatus(errors.ErrNotFound, http.StatusNotFound),
},
{
desc: "update group metadata with invalid group id",
group: sdk.Group{
ID: gmocks.WrongID,
Metadata: sdk.Metadata{
"field": "value2",
},
},
response: sdk.Group{},
token: validToken,
err: errors.NewSDKErrorWithStatus(errors.ErrNotFound, http.StatusNotFound),
},
{
desc: "update group name with invalid token",
group: sdk.Group{
ID: group.ID,
Name: "NewName",
},
response: sdk.Group{},
token: invalidToken,
err: errors.NewSDKErrorWithStatus(errors.Wrap(errors.ErrAuthentication, sdk.ErrInvalidJWT), http.StatusUnauthorized),
},
{
desc: "update group description with invalid token",
group: sdk.Group{
ID: group.ID,
Description: "NewDescription",
},
response: sdk.Group{},
token: invalidToken,
err: errors.NewSDKErrorWithStatus(errors.Wrap(errors.ErrAuthentication, sdk.ErrInvalidJWT), http.StatusUnauthorized),
},
{
desc: "update group metadata with invalid token",
group: sdk.Group{
ID: group.ID,
Metadata: sdk.Metadata{
"field": "value2",
},
},
response: sdk.Group{},
token: invalidToken,
err: errors.NewSDKErrorWithStatus(errors.Wrap(errors.ErrAuthentication, sdk.ErrInvalidJWT), http.StatusUnauthorized),
},
{
desc: "update a group that can't be marshalled",
group: sdk.Group{
Name: "test",
Metadata: map[string]interface{}{
"test": make(chan int),
},
},
response: sdk.Group{},
token: token,
err: errors.NewSDKError(fmt.Errorf("json: unsupported type: chan int")),
},
}
for _, tc := range cases {
repoCall1 := gRepo.On("Update", mock.Anything, mock.Anything).Return(convertGroup(tc.response), tc.err)
_, err := mfsdk.UpdateGroup(tc.group, tc.token)
assert.Equal(t, tc.err, err, fmt.Sprintf("%s: expected error %s, got %s", tc.desc, tc.err, err))
if tc.err == nil {
ok := repoCall1.Parent.AssertCalled(t, "Update", mock.Anything, mock.Anything)
assert.True(t, ok, fmt.Sprintf("Update was not called on %s", tc.desc))
}
repoCall1.Unset()
}
}
func TestEnableGroup(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
creationTime := time.Now().UTC()
group := sdk.Group{
ID: generateUUID(t),
Name: gName,
OwnerID: generateUUID(t),
CreatedAt: creationTime,
UpdatedAt: creationTime,
Status: clients.Disabled,
}
repoCall1 := gRepo.On("RetrieveByID", mock.Anything, mock.Anything).Return(nil)
repoCall2 := gRepo.On("ChangeStatus", mock.Anything, mock.Anything).Return(sdk.ErrFailedRemoval)
_, err := mfsdk.EnableGroup("wrongID", validToken)
assert.Equal(t, err, errors.NewSDKErrorWithStatus(errors.ErrNotFound, http.StatusNotFound), fmt.Sprintf("Enable group with wrong id: expected %v got %v", errors.ErrNotFound, err))
ok := repoCall1.Parent.AssertCalled(t, "RetrieveByID", mock.Anything, "wrongID")
assert.True(t, ok, "RetrieveByID was not called on enabling group")
repoCall1.Unset()
repoCall2.Unset()
g := mfgroups.Group{
ID: group.ID,
Name: group.Name,
Owner: group.OwnerID,
CreatedAt: creationTime,
UpdatedAt: creationTime,
Status: clients.DisabledStatus,
}
repoCall1 = gRepo.On("RetrieveByID", mock.Anything, mock.Anything).Return(g, nil)
repoCall2 = gRepo.On("ChangeStatus", mock.Anything, mock.Anything).Return(g, nil)
res, err := mfsdk.EnableGroup(group.ID, validToken)
assert.Nil(t, err, fmt.Sprintf("Enable group with correct id: expected %v got %v", nil, err))
assert.Equal(t, group, res, fmt.Sprintf("Enable group with correct id: expected %v got %v", group, res))
ok = repoCall1.Parent.AssertCalled(t, "RetrieveByID", mock.Anything, group.ID)
assert.True(t, ok, "RetrieveByID was not called on enabling group")
ok = repoCall2.Parent.AssertCalled(t, "ChangeStatus", mock.Anything, mock.Anything)
assert.True(t, ok, "ChangeStatus was not called on enabling group")
repoCall1.Unset()
repoCall2.Unset()
}
func TestDisableGroup(t *testing.T) {
ts, _, gRepo, _ := newGroupsServer()
defer ts.Close()
conf := sdk.Config{
UsersURL: ts.URL,
}
mfsdk := sdk.NewSDK(conf)
creationTime := time.Now().UTC()
group := sdk.Group{
ID: generateUUID(t),
Name: gName,
OwnerID: generateUUID(t),
CreatedAt: creationTime,
UpdatedAt: creationTime,
Status: clients.Enabled,
}
repoCall1 := gRepo.On("ChangeStatus", mock.Anything, mock.Anything).Return(sdk.ErrFailedRemoval)
repoCall2 := gRepo.On("RetrieveByID", mock.Anything, mock.Anything).Return(nil)
_, err := mfsdk.DisableGroup("wrongID", validToken)
assert.Equal(t, err, errors.NewSDKErrorWithStatus(errors.ErrNotFound, http.StatusNotFound), fmt.Sprintf("Disable group with wrong id: expected %v got %v", errors.ErrNotFound, err))
ok := repoCall1.Parent.AssertCalled(t, "RetrieveByID", mock.Anything, "wrongID")
assert.True(t, ok, "Memberships was not called on disabling group with wrong id")
repoCall1.Unset()
repoCall2.Unset()
g := mfgroups.Group{
ID: group.ID,
Name: group.Name,
Owner: group.OwnerID,
CreatedAt: creationTime,
UpdatedAt: creationTime,
Status: clients.EnabledStatus,
}
repoCall1 = gRepo.On("ChangeStatus", mock.Anything, mock.Anything).Return(g, nil)
repoCall2 = gRepo.On("RetrieveByID", mock.Anything, mock.Anything).Return(g, nil)
res, err := mfsdk.DisableGroup(group.ID, validToken)
assert.Nil(t, err, fmt.Sprintf("Disable group with correct id: expected %v got %v", nil, err))
assert.Equal(t, group, res, fmt.Sprintf("Disable group with correct id: expected %v got %v", group, res))
ok = repoCall1.Parent.AssertCalled(t, "RetrieveByID", mock.Anything, group.ID)
assert.True(t, ok, "RetrieveByID was not called on disabling group with correct id")
ok = repoCall2.Parent.AssertCalled(t, "ChangeStatus", mock.Anything, mock.Anything)
assert.True(t, ok, "ChangeStatus was not called on disabling group with correct id")
repoCall1.Unset()
repoCall2.Unset()
}